linux-kernel - Re: [patch 07/10] m68knommu: Convert 5272 intc irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1102081047020.31804@localhost6.localdomain6>
Date:	Tue, 8 Feb 2011 10:48:31 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Greg Ungerer <gerg@...pgear.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Greg Ungerer <gerg@...inux.org>
Subject: Re: [patch 07/10] m68knommu: Convert 5272 intc irq_chip to new
 functions

On Tue, 8 Feb 2011, Greg Ungerer wrote:
> >  static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
> >  {
> > -	desc->chip->ack(irq);
> > +	get_irq_desc_chip(i)->irq_ack(desc->irq_data);
>                          ^^^         ^^^
> should this be:
> 
>         get_irq_desc_chip(desc)->irq_ack(&desc->irq_data)

Yes.
 
> I can't runtime test this right at the moment, but otherwise:
> 
> Acked-by: Greg Ungerer <gerg@...inux.org>

Can you push that stuff linus wards for 39 or want me to do it ? It
has no dependencies whatsoever.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/