linux-kernel - Re: [PATCH 00/14] POWER: BQ27x00: New Properties, fixes, bq27000 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110208162802.GA29842@oksana.dev.rtsoft.ru>
Date:	Tue, 8 Feb 2011 19:28:02 +0300
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Grazvydas Ignotas <notasas@...il.com>,
	Rodolfo Giometti <giometti@...ux.it>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/14] POWER: BQ27x00: New Properties, fixes, bq27000
 support

On Tue, Feb 08, 2011 at 05:13:47PM +0100, Lars-Peter Clausen wrote:
> On 02/08/2011 12:40 PM, Grazvydas Ignotas wrote:
> > That works. However I wonder about the delay, I've experimentally
> > determined that bq27500 refreshes in about a second, so before this
> > series I could for example run 'watch -n 1 cat current_now' and see
> > current changes almost in realtime (when toggling backlight, for
> > example). Maybe we could have different cache timeout for different
> > chips or have quickly changing properties (like current and voltage)
> > bypass the cache.
> 
> Looking at the datasheet confirms that the bq27500 updates the current register
> every second. The bq27000 updates it only every 5.12 seconds.
> I think reducing the the cache time for bq27500 to 1 second would render the
> cache mostly useless, but maybe it makes sense to bypass the cache for voltage
> and current on the bq27500.

Nope, it's not useless. I.e. for `cat /sys/class/power_supply/*/*`.
Actually, it was only the purpose for caching the battery values.

So, 1 second is OK.

p.s. Lars, on the next resend, can you please remove "POWER:"
prefix from the patch description line, bound the commit message
width to 76 symbols, and add all the collected Acked-by lines.
That way I can just pull your tree.

Thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/