linux-kernel - Re: [PATCH] x86: fix setup NMI_LOCAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110208173836.GA27728@redhat.com>
Date:	Tue, 8 Feb 2011 12:38:36 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Hillf Danton <dhillf@...il.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: fix setup NMI_LOCAL_APIC watchdog

On Thu, Feb 03, 2011 at 11:07:11PM +0800, Hillf Danton wrote:
> when testing NMI watchdog, at leat for NMI_LOCAL_APIC, the default
> value of nmi_active could prevent the dog from being tested. Even
> could not, lapic_adjust_nmi_hz() could misplay its role since the
> underlying hardware is still not initialized by lapic_watchdog_init().
> 
> And for same reason the check for wd_ops could be removed in
> enable_lapic_nmi_watchdog(), in which nmi_active is also checked.
> 
> If NMI_LOCAL_APIC is enabled thru sysctl on cmdline after bootup, how
> to test stuckup?

Your patch doesn't apply to 2.6.38 any more because that code has been
removed.  We have switched to the new nmi_watchdog.  Unless you have other
concerns, I am going to drop your patch.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/