lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 8 Feb 2011 20:36:02 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	james_p_freyensee@...ux.intel.com, gregkh@...e.de,
	linux-kernel@...r.kernel.org, suhail.ahmed@...el.com
Subject: Re: [PATCH 01/12] export kernel call get_task_comm()

On Tue, 8 Feb 2011 15:28:56 -0500
Christoph Hellwig <hch@...radead.org> wrote:

> On Tue, Feb 08, 2011 at 08:28:52PM +0000, Alan Cox wrote:
> > On Tue, 8 Feb 2011 11:44:16 -0800 (PST)
> > > > From current you can just dereference current->comm, and access from
> > > > other threads from drivers is a bad idea.
> > 
> > You need to take the locks for it - which get_task_comm encapsulates.
> 
> Not for current->comm, which is the only thing it cares about.

Which is a detail you really don't want to leak out of the proper
abstraction use. I really don't see why you are advocating bad
programming practice - everything else uses the abstraction properly,
this just happens to be the first modular case that wants to behave
properly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists