linux-kernel - Re: PATCH: drivers/staging/lirc/lirc_serial.c: use IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D51B6EF.5000409@teksavvy.com>
Date:	Tue, 08 Feb 2011 16:34:39 -0500
From:	Mark Lord <kernel@...savvy.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jarod Wilson <jarod@...sonet.com>,
	Greg Kroah-Hartman <greg@...ah.com>
Subject: Re: PATCH: drivers/staging/lirc/lirc_serial.c: use IS_ERR()

On 11-02-06 03:39 PM, Mark Lord wrote:
> The lirc_serial.c module has never worked with ordinary homebrew
> serial blaster hardware, and leaks memory when this is attempted.
> 
> Fix it by replacing incorrect usage of PTR_ERR() with IS_ERR().
> (patch is inline and also attached to bypass mailer issues).
> 
> Signed-off-by: Mark Lord <mlord@...ox.com>
> 
> --- linux-2.6.37/drivers/staging/lirc/lirc_serial.c	2011-01-04
> 19:50:19.000000000 -0500
> +++ linux/drivers/staging/lirc/lirc_serial.c	2011-02-06 15:33:49.854453928 -0500
> @@ -966,7 +966,7 @@
>  	if (n % sizeof(int) || count % 2 == 0)
>  		return -EINVAL;
>  	wbuf = memdup_user(buf, n);
> -	if (PTR_ERR(wbuf))
> +	if (IS_ERR(wbuf))
>  		return PTR_ERR(wbuf);
>  	spin_lock_irqsave(&hardware[type].lock, flags);
>  	if (type == LIRC_IRDEO) {


Anyone out there?

Greg?

View attachment "lirc_serial_fix.patch" of type "text/x-patch" (429 bytes)