linux-kernel - Re: [PATCH] tpm_tis: Use timeouts returned from TPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 08 Feb 2011 20:06:00 -0200
From:	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
To:	Guillaume Chazarain <guichaz@...il.com>
CC:	Stefan Berger <stefanb@...ux.vnet.ibm.com>,
	James Morris <jmorris@...ei.org>, linux-kernel@...r.kernel.org,
	tpmdd-devel@...ts.sourceforge.net
Subject: Re: [PATCH] tpm_tis: Use timeouts returned from TPM

On 02/08/2011 07:45 PM, Guillaume Chazarain wrote:
> [ + jmorris ]
>
> On Thu, Jan 27, 2011 at 11:44 PM, Guillaume Chazarain<guichaz@...il.com>  wrote:
>> On Tue, Jan 11, 2011 at 8:37 PM, Stefan Berger
>> <stefanb@...ux.vnet.ibm.com>  wrote:
>>> The current TPM TIS driver in git discards the timeout values returned
>>> from the TPM.
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c4ff4b829ef9e6353c0b133b7adb564a68054979
>> broke the TPM for me on a thinkpad T410. When using the TPM, dmesg
>> complains:
>>
>> [   65.728310] tpm_tis 00:0b: Operation Timed out
>> [   67.651450] tpm_tis 00:0b: Operation Timed out
>> [   69.669421] tpm_tis 00:0b: Operation Timed out
>>
>> This patch fixes it, so consider it:
>>
>> Tested-by: Guillaume Chazarain<guichaz@...il.com>
> This patch (https://lkml.org/lkml/2011/1/11/341) fixes a regression
> introduced in 2.6.38-rc3, any chance of having it merged?
>
> Thanks.

This patch solves a bug existent before the commit that made into 
2.6.38-rc3. Prior to such commit, the device driver was using default 
values that were big enough to allow TPM commands to succeed, but that 
stalled the kernel for too long during boot (2 minutes for each command 
sent) when buggy TPMs don't respond.

I'll apply this patch to my tree, and ask James to pull from it.

Rajiv



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/