linux-kernel - Re: [PATCH v2 2/2] man-pages: SYSLOG_ACTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110208223251.GP1457@outflux.net>
Date:	Tue, 8 Feb 2011 14:32:51 -0800
From:	Kees Cook <kees.cook@...onical.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Arnd Bergmann <arnd@...db.de>, mtk.manpages@...il.com,
	Serge Hallyn <serge.hallyn@...onical.com>
Subject: Re: [PATCH v2 2/2] man-pages: SYSLOG_ACTION_* constants are now
 exported

On Tue, Feb 08, 2011 at 11:15:34PM +0100, Paul Bolle wrote:
> The kernel now exports <linux/syslog.h>. This makes the SYSLOG_ACTION_*
> constants available to userspace. This allows to replace the magic
> numbers used in this man page with (what should be) more descriptive
> names. The quote form kernel/printk.c can now also be dropped.
> 
> A few (more or less related) things were also fixed or changed:
> - add a new sub section "The command types";
> - the (userspace) buffer is called bufp everywhere (and not buf);
> - add some whitespace to all call descriptions;
> - use "ignored" in some call descriptions (instead of "dummy").
> 
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Acked-by: Kees Cook <kees.cook@...onical.com>


As an aside, it might be a good idea to send an additional patch (since
it's logically separate from this) to update this portion of the man-page:

   EPERM  An attempt was made to change console_loglevel or clear the
          kernel message ring buffer by a process without  sufficient
          privi lege (more precisely: without the CAP_SYS_ADMIN capability).

At least s/CAP_SYS_ADMIN/CAP_SYSLOG/, but probably include details about
which options are considered privileged.

Though that should probably go with including the description of CAP_SYSLOG
in the "capabilities" man-page.

-Kees

-- 
Kees Cook
Ubuntu Security Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/