linux-kernel - Re: [tip:perf/core] perf annotate: Fix annotate context lines regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Feb 2011 14:41:54 -0200
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Mike Galbraith <efault@....de>
Cc:	mingo@...hat.com, hpa@...or.com, paulus@...ba.org,
	eranian@...gle.com, linux-kernel@...r.kernel.org,
	tzanussi@...il.com, peterz@...radead.org, fweisbec@...il.com,
	tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] perf annotate: Fix annotate context lines
	regression

Em Wed, Feb 09, 2011 at 05:06:18AM +0100, Mike Galbraith escreveu:
> On Wed, 2011-02-09 at 00:43 +0000, tip-bot for Arnaldo Carvalho de Melo wrote
> > Gitweb:     http://git.kernel.org/tip/d5e3d747007fdb541e57ed72e020ff0b94db3470
> > Author:     Arnaldo Carvalho de Melo <acme@...hat.com>
> > 
> > perf annotate: Fix annotate context lines regression
> > 
> > The live annotation done in 'perf top' needs to limit the context before
> > lines that aren't filtered out by the min percent filter, if we don't do
> > that, the screen in a tty often is not enough for showing what is
> > interesting: lines with hits and a few source code lines before it.
> 
> Looks to me like this went from regress a bit while waiting for tui
> thing to progress a bit immediately :)

:-) Can you please apply the two patches and give 'perf top --tui' live
annotation a shot? Just press enter or -> (right key) on a symbol you
want to annotate.

I'm still polishing it a bit, want to avoid trying the notes->lock on
each time record_precise_ip is called, for that I need to share the
current symbol being annotated (sym_filter_entry) with the annotate
browser, the timer should not always run, etc, but just so that I can
get some feedback on how it is shaping up, please try it and report your
impressions :-)

Also when enter is pressed and one is monitoring multiple events, a
popup menu with the event names should be presented, etc.

- Arnaldo

View attachment "0001-perf-ui-Serialize-screen-updates.patch" of type "text/plain" (4649 bytes)

View attachment "0002-live_tui_annotate.patch" of type "text/plain" (8817 bytes)