linux-kernel - Re: [PATCH 0/10] Add yaffs2 file system: Fifth patchset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Feb 2011 07:22:47 +1300
From:	Charles Manning <manningc2@...rix.gen.nz>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Charles Manning <cdhmanning@...il.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	ryan@...ewatersys.com, akpm@...ux-foundation.org
Subject: Re: [PATCH 0/10] Add yaffs2 file system:  Fifth patchset

On Wednesday 09 February 2011 17:52:21 Christoph Hellwig wrote:
> On Wed, Feb 09, 2011 at 04:25:58PM +1300, Charles Manning wrote:
> > Comments/feedback welcome, but I'm hopefully getting pretty close to
> > acceptance :-).
>
> It's not anywhere near ready as long as you insist keeping that silly
> Linux glue code.  

Can you be a bit more specific?

Did you actually look or did you just get hives when you saw "glue code"? The 
current glue code is very far from what was in the original patch set. In the 
first set there were all sorts of abstractions which have been purged and 
almost entirely removed.

The current "glue code" really just partitions off the vfs interaction from 
the file system internal operations.

This partitioning serves a purpose: it allows the code to be easily integrated 
into applications etc (ie outside of the kernel) and also allows the 
multi-version code to be supported more cleanly. Multi-version is incredibly 
important in the RealWorld (TM).

> Also make sure it passes the xfstests QA suite 
> (http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=summary), which
> might need a bit work to be made run depending on how quirky your
> mkfs/fsck tools are.

Thanks. I'll try those.

It does pass fsx and some other tests.

-- Charles

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/