linux-kernel - Re: CONFIG_KERNEL_XZ obscure build failure if xz(1) not installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D5304F2.7000404@zytor.com>
Date:	Wed, 09 Feb 2011 13:19:46 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andy Isaacson <adi@...apodia.org>
CC:	linux-kernel@...r.kernel.org,
	Lasse Collin <lasse.collin@...aani.org>
Subject: Re: CONFIG_KERNEL_XZ obscure build failure if xz(1) not installed

On 02/09/2011 11:52 AM, Andy Isaacson wrote:
> 
> The failure is obscured by trailing make output, and since a broken
> bzImage is created, "make install" succeeds, and the first visible
> failure is after reboot when I get the lovely
> 
>     Decompressing Linux...
> 
>     Input is not in the XZ format (wrong magic bytes)
> 
>      -- System halted
> 
> Sometimes I run "make -j4 && make install" which would have caught this,
> but the error should be more prominent and we shouldn't create bzImage
> if the dependencies are not present.
> 

Agreed that the bzImage should not have been created.  That should make
the error prominent enough (your complaint that it gets obscured with
make -j is "just how things work, sorry.")

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/