linux-kernel - Re: [RFC][PATCH 2/4] ftrace: Add -mfentry to Makefile on function tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D53057B.6020008@zytor.com>
Date:	Wed, 09 Feb 2011 13:22:03 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andi Kleen <andi@...stfloor.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Michal Marek <mmarek@...e.cz>
Subject: Re: [RFC][PATCH 2/4] ftrace: Add -mfentry to Makefile on function
 tracer

On 02/09/2011 12:28 PM, Steven Rostedt wrote:
> On Wed, 2011-02-09 at 15:02 -0500, Steven Rostedt wrote:
> 
>>  ifdef CONFIG_FUNCTION_TRACER
>> -KBUILD_CFLAGS	+= -pg
>> +ifdef CONFIG_HAVE_FENTRY
>> +CC_HAS_FENTRY	:= $(call cc-option, -mfentry -DCC_HAS_FENTRY)
> 
> I should include a thanks to H. Peter Anvin in the change log for
> telling me about the cc-option trick.
> 

Actually we should probably calling this -DCC_USING_FENTRY or something
like that, since as coded above it includes the CONFIG_FUNCTION_TRACER
dependency.  This is a good thing -- it makes the conditionals easier --
we just also want to make sure they don't get misunderstood.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/