| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Feb 2011 13:37:57 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Johannes Weiner <hannes@...xchg.org> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, Daisuke Nishimura <nishimura@....nes.nec.co.jp>, Balbir Singh <balbir@...ux.vnet.ibm.com>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org> Subject: Re: [patch 0/4] memcg: operate on page quantities internally On Wed, 9 Feb 2011 12:01:49 +0100 Johannes Weiner <hannes@...xchg.org> wrote: > Hi, > > this patch set converts the memcg charge and uncharge paths to operate > on multiples of pages instead of bytes. It already was a good idea > before, but with the merge of THP we made a real mess by specifying > huge pages alternatingly in bytes or in number of regular pages. > > If I did not miss anything, this should leave only res_counter and > user-visible stuff in bytes. The ABI probably won't change, so next > up is converting res_counter to operate on page quantities. > I worry that there will be unconverted code and we'll end up adding bugs. A way to minimise the risk is to force compilation errors and warnings: rename fields and functions, reorder function arguments. Did your patches do this as much as they could have? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists