linux-kernel - Re: [RFC][PATCH] cgroup: Fix cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D5347C9.2030909@cn.fujitsu.com>
Date:	Thu, 10 Feb 2011 10:04:57 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Paul Menage <menage@...gle.com>, balbir@...ux.vnet.ibm.com,
	eranian@...gle.com, linux-kernel@...r.kernel.org, mingo@...e.hu,
	paulus@...ba.org, davem@...emloft.net, fweisbec@...il.com,
	perfmon2-devel@...ts.sf.net, eranian@...il.com,
	robert.richter@....com, acme@...hat.com
Subject: Re: [RFC][PATCH] cgroup: Fix cgroup_subsys::exit callback

(just came back from vacation)

>> How about if the exit callback was moved before the preceding
>> task_unlock()? Since I think the scheduler is still the only user of
>> the exit callback, redefining the locking semantics should be fine.
> 
> Like the below? Both the perf and sched exit callback are fine with
> being called under task_lock afaict, but I haven't actually ran with
> lockdep enabled to see if I missed something.
> 

This change should be fine.

...

> +
> +	if (run_callbacks && need_forkexit_callback) {
> +		/*
> +		 * modular subsystems can't use callbacks, so no need to lock
> +		 * the subsys array
> +		 */
> +		for (i = 0; i < CGROUP_BUILTIN_SUBSYS_COUNT; i++) {
> +			struct cgroup_subsys *ss = subsys[i];
> +			if (ss->exit) {
> +				struct cgroup *old_cgrp =
> +					rcu_dereference_raw(cg->subsys[i])->cgroup;
> +				struct cgroup *cgrp = task_cgroup(tsk, i);
> +				ss->exit(ss, cgrp, old_cgrp, tsk);

Since both sched and perf won't use the 2 args @cgrp and @old_cgrp,
don't bother to change the ->exit interface?

> +			}
> +		}
> +	}
>  	task_unlock(tsk);
> +
>  	if (cg)
>  		put_css_set_taskexit(cg);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/