linux-kernel - Re: [RFC PATCH 06/13] Intel(R) MEI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110210135232.4f87df85@lxorguk.ukuu.org.uk>
Date:	Thu, 10 Feb 2011 13:52:32 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Oren Weil <oren.jer.weil@...el.com>
Cc:	gregkh@...e.de, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, david@...dhou.se,
	david.woodhouse@...el.com
Subject: Re: [RFC PATCH 06/13] Intel(R) MEI Driver

> +/**
> + * flow_ctrl_creds - checks flow_control credentials.

There seem to be an enormous number of global variables and not all of
them have mei_xxx prefixes on either.

I can't tell if this is because the driver wants restructuring as there
simply isn't an overall visible architecture or design to the code I can
see, nor any documentation on what it is doing at the higher levels or
the API.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/