linux-kernel - Re: [PATCH -next] kobject.h: fix build when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110210093847.995e6f97.randy.dunlap@oracle.com>
Date:	Thu, 10 Feb 2011 09:38:47 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	gregkh@...e.de
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] kobject.h: fix build when CONFIG_HOTPLUG is
 disabled

On Sun, 6 Feb 2011 21:57:18 -0800 Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> When CONFIG_HOTPLUG is not enabled, the inline function add_uevent_var()
> needs to have its __attribute__ before the function name/parameters,
> otherwise there are syntax errors.
> 
> linux-next-20110207/include/linux/kobject.h:232: error: expected ',' or ';' before '{' token
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Greg,
This patch is still needed in linux-next, please...


> ---
>  include/linux/kobject.h |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> --- linux/include/linux/kobject.h.ORG	2011-02-06 21:47:23.000000000 -0800
> +++ linux/include/linux/kobject.h	2011-02-06 21:44:56.000000000 -0800
> @@ -226,9 +226,8 @@
>  				      char *envp[])
>  { return 0; }
>  
> -static inline int add_uevent_var(struct kobj_uevent_env *env,
> -				 const char *format, ...)
> -	__attribute__((format(printf, 2, 3)))
> +static inline __attribute__((format(printf, 2, 3)))
> +int add_uevent_var(struct kobj_uevent_env *env, const char *format, ...)
>  { return 0; }
>  
>  static inline int kobject_action_type(const char *buf, size_t count,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-next" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/