linux-kernel - Re: [RFC PATCH 02/13] Intel(R) MEI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110210180145.GE13795@suse.de>
Date:	Thu, 10 Feb 2011 10:01:45 -0800
From:	Greg KH <gregkh@...e.de>
To:	Oren Weil <oren.jer.weil@...el.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	david@...dhou.se, david.woodhouse@...el.com
Subject: Re: [RFC PATCH 02/13] Intel(R) MEI Driver

On Thu, Feb 10, 2011 at 01:55:00AM -0800, Oren Weil wrote:
> diff --git a/drivers/char/Makefile b/drivers/char/Makefile

No description, or signed-off-by lines.  Have you read how to properly
create and submit a patch?  If so, why did you ignore those rules?

> index 5bc765d..e43ea27 100644
> --- a/drivers/char/Makefile
> +++ b/drivers/char/Makefile
> @@ -84,4 +84,5 @@ obj-$(CONFIG_PS3_FLASH)		+= ps3flash.o
>  obj-$(CONFIG_RAMOOPS)		+= ramoops.o
>  
>  obj-$(CONFIG_JS_RTC)		+= js-rtc.o
> +obj-$(CONFIG_INTEL_MEI)		+= mei/

You just broke the build.

I'm not going to review farther, it's a waste of my, and every one
else's time.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/