linux-kernel - Re: [PATCH v5 0/4] Adding HID Feature Report Support to hidraw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110210181441.GB2173@joana>
Date:	Thu, 10 Feb 2011 16:14:41 -0200
From:	"Gustavo F. Padovan" <padovan@...fusion.mobi>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Alan Ott <alan@...nal11.us>, Marcel Holtmann <marcel@...tmann.org>,
	"David S. Miller" <davem@...emloft.net>,
	Michael Poole <mdpoole@...ilus.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-bluetooth@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v5 0/4] Adding HID Feature Report Support to hidraw

Hi Jiri,

* Jiri Kosina <jkosina@...e.cz> [2011-01-19 13:17:00 +0100]:

> On Tue, 18 Jan 2011, Alan Ott wrote:
> 
> > This patch adds Feature Report support for USB and Bluetooth HID devices
> > through hidraw.
> > 
> > The first two patches prepare the bluetooth side for the change.
> > 	a. Make sure the hidp_session() thread is started before
> > 	   device's probe() functions are called.
> > 	b. Wait for ACK/NAK on sent reports, and return proper
> > 	   error codes.
> > The third patch is the hidraw core and USB changes.
> > The fourth patch is the Bluetooth changes.
> > 
> > Thanks to Antonio Ospite and Bill Good for providing testing and feedback.
> > 
> > 
> > Alan Ott (4):
> >   bt hidp: Move hid_add_device() call to after hidp_session() has
> >     started.
> >   bt hidp: Wait for ACK on Sent Reports
> >   HID: Add Support for Setting and Getting Feature Reports from hidraw
> >   Bluetooth hidp: Add support for hidraw HIDIOCGFEATURE and
> >     HIDIOCSFEATURE
> > 
> >  drivers/hid/hidraw.c          |  106 +++++++++++++++++++-
> >  drivers/hid/usbhid/hid-core.c |   35 +++++++
> >  include/linux/hid.h           |    3 +
> >  include/linux/hidraw.h        |    3 +
> >  net/bluetooth/hidp/core.c     |  214 ++++++++++++++++++++++++++++++++++++++---
> >  net/bluetooth/hidp/hidp.h     |   15 +++
> 
> Before proceeding with these patches, I'd really like to have comment 
> (ideally 'Acked-by') from Marcel on the net/bluetooth/hidp part, 
> obviously.

I have tested it and it seems ok to me and to Marcel. For net/bluetooth/

Acked-by: Gustavo F. Padovan <padovan@...fusion.mobi>

Regards,

-- 
Gustavo F. Padovan
http://profusion.mobi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/