linux-kernel - Re: [PATCH 1/1] cap_syslog: don't refuse cap_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin-2uDkjPuSPmUE_HZdpxk9zd=Qop=nf==jsyLA@mail.gmail.com>
Date:	Thu, 10 Feb 2011 11:16:58 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Serge E. Hallyn" <serge@...lyn.com>
Cc:	Gergely Nagy <algernon@...abit.hu>, david@...g.hm,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Marc Koschewski <marc@...nowledge.org>,
	lkml <linux-kernel@...r.kernel.org>,
	James Morris <jmorris@...ei.org>,
	Nick Bowler <nbowler@...iptictech.com>
Subject: Re: [PATCH 1/1] cap_syslog: don't refuse cap_sys_admin for now (v3)

On Thu, Feb 10, 2011 at 6:40 AM, Serge E. Hallyn <serge@...lyn.com> wrote:
>
> Please apply.

Hmm. So I detest the duplication and the ugly resulting code.  It was
a bit hard to follow before, now it's just nasty.

Why not make this all into some nicer helper functions instead -
something simple like the attached?

UNTESTED! I'm not going to apply it unless I get acks/tested-by's.

                                  Linus

View attachment "patch.diff" of type "text/x-patch" (2304 bytes)