linux-kernel - Re: [PULL] cpumask offstack finalization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinMsD664FiDZy2ZtVo2jtH0x7m30EyMay9REmwj@mail.gmail.com>
Date:	Thu, 10 Feb 2011 15:51:07 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Rusty Russell <rusty@...tcorp.com.au>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, anton@...ba.org,
	Mike Travis <travis@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PULL] cpumask offstack finalization

On Thu, Feb 10, 2011 at 2:13 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
>
> Wrong. __deprecated is not annoying enough.

Wrong.

The problem with __deprecated is that it is a F*CKING STUPID thing to
have, and I've wanted to remove it so many times.

It's annoying as hell, but it's annoying to the wrong people. It
doesn't annoy the people who need to fix things up (they may have one
or two cases they care about), it annoys everybody ELSE (who sees all
the cases that it warns about, whether they are able to do something
about it or not).

THAT is the fundamental problem with __deprecated. It's annoying, but
the annoyance is spread out entirely incorrectly. Even to people for
whom one of the warnings might be relevant, it's pointless, because
all the non-relevant cases it triggers.

So never _ever_ mark anything "deprecated". If you want to get rid of
something, get rid of it and fix the callers. Don't say "somebody else
should get rid of it, because it's deprecated".

And yes, next time this discussion comes up, I _will_ remove that
piece-of-sh*t. It's a disease. It's just a stupid way to say "somebody
else should deal with this problem". It's a way to make excuses. It's
crap. It was a mistake to ever take any of that to begin with.

                               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/