linux-kernel - Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Feb 2011 12:58:21 +0900
From:	Ryota Ozaki <ozaki.ryota@...il.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Hugh Dickins <hughd@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions

On Thu, Feb 10, 2011 at 8:58 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@...fujitsu.com> wrote:
> On Wed,  9 Feb 2011 23:42:17 +0900
> Ryota Ozaki <ozaki.ryota@...il.com> wrote:
>
>> From: Ryota Ozaki <ozaki.ryota@...il.com>
>>
>> do_file_page and do_no_page don't exist anymore, but some comments
>> still refers them. The patch fixes them by replacing them with
>> existing ones.
>>
>> Signed-off-by: Ryota Ozaki <ozaki.ryota@...il.com>
>
> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

Thanks, Kamezawa-san.

>
> It seems there are other ones ;)
> ==
>    Searched full:do_no_page (Results 1 - 3 of 3) sorted by relevancy
>
>  /linux-2.6-git/arch/alpha/include/asm/
> H A D   cacheflush.h    66 /* This is used only in do_no_page and do_swap_page. */
>  /linux-2.6-git/arch/avr32/mm/
> H A D   cache.c         116 * This one is called from do_no_page(), do_swap_page() and install_page().
>  /linux-2.6-git/mm/
> H A D   memory.c        2121 * and do_anonymous_page and do_no_page can safely check later on).
> 2319 * do_no_page is protected similarly.

Nice catch :-) Cloud I assemble all fixes into one patch?

  ozaki-r

>
>
>
>
>
>> ---
>>  mm/memory.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> I'm not familiar with the codes very much, so the fix may be wrong.
>>
>> diff --git a/mm/memory.c b/mm/memory.c
>> index 31250fa..3fbf32a 100644
>> --- a/mm/memory.c
>> +++ b/mm/memory.c
>> @@ -2115,10 +2115,10 @@ EXPORT_SYMBOL_GPL(apply_to_page_range);
>>   * handle_pte_fault chooses page fault handler according to an entry
>>   * which was read non-atomically.  Before making any commitment, on
>>   * those architectures or configurations (e.g. i386 with PAE) which
>> - * might give a mix of unmatched parts, do_swap_page and do_file_page
>> + * might give a mix of unmatched parts, do_swap_page and do_nonlinear_fault
>>   * must check under lock before unmapping the pte and proceeding
>>   * (but do_wp_page is only called after already making such a check;
>> - * and do_anonymous_page and do_no_page can safely check later on).
>> + * and do_anonymous_page can safely check later on).
>>   */
>>  static inline int pte_unmap_same(struct mm_struct *mm, pmd_t *pmd,
>>                               pte_t *page_table, pte_t orig_pte)
>> @@ -2316,7 +2316,7 @@ reuse:
>>                * bit after it clear all dirty ptes, but before a racing
>>                * do_wp_page installs a dirty pte.
>>                *
>> -              * do_no_page is protected similarly.
>> +              * __do_fault is protected similarly.
>>                */
>>               if (!page_mkwrite) {
>>                       wait_on_page_locked(dirty_page);
>> --
>> 1.7.2.3
>>
>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/