linux-kernel - Re: [PATCH] Input: fixed EVIOCGRAB iterative grab/release.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110210235447.GA12313@core.coreip.homeip.net>
Date:	Thu, 10 Feb 2011 15:54:47 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	tlambert@...omium.org
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: fixed EVIOCGRAB iterative grab/release.

On Thu, Feb 10, 2011 at 03:42:50PM -0800, tlambert@...omium.org wrote:
> From: Terry Lambert <tlambert@...omium.org>
> 
> Fixed order of calls in evdev_ungrab to allow iterative use of
> code which grabs and releases input event devices.
> 

Sorry, could you  please be more verbose?

> Signed-off-by: Terry Lambert <tlambert@...omium.org>
> ---
>  drivers/input/evdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
> index c8471a2..0bac8da 100644
> --- a/drivers/input/evdev.c
> +++ b/drivers/input/evdev.c
> @@ -160,9 +160,9 @@ static int evdev_ungrab(struct evdev *evdev, struct evdev_client *client)
>  	if (evdev->grab != client)
>  		return  -EINVAL;
>  
> +	input_release_device(&evdev->handle);
>  	rcu_assign_pointer(evdev->grab, NULL);
>  	synchronize_rcu();
> -	input_release_device(&evdev->handle);
>  
>  	return 0;
>  }
> -- 
> 1.7.3.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/