linux-kernel - Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik36rhvou2Bu99LMkAXx+BYQJysPxZG1gAAJwyv@mail.gmail.com>
Date:	Thu, 10 Feb 2011 13:44:09 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Ryota Ozaki <ozaki.ryota@...il.com>
Cc:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Hugh Dickins <hughd@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions

On Thu, Feb 10, 2011 at 12:58 PM, Ryota Ozaki <ozaki.ryota@...il.com> wrote:
> On Thu, Feb 10, 2011 at 8:58 AM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@...fujitsu.com> wrote:
>> On Wed,  9 Feb 2011 23:42:17 +0900
>> Ryota Ozaki <ozaki.ryota@...il.com> wrote:
>>
>>> From: Ryota Ozaki <ozaki.ryota@...il.com>
>>>
>>> do_file_page and do_no_page don't exist anymore, but some comments
>>> still refers them. The patch fixes them by replacing them with
>>> existing ones.
>>>
>>> Signed-off-by: Ryota Ozaki <ozaki.ryota@...il.com>
>>
>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>
> Thanks, Kamezawa-san.
>
>>
>> It seems there are other ones ;)
>> ==
>>    Searched full:do_no_page (Results 1 - 3 of 3) sorted by relevancy
>>
>>  /linux-2.6-git/arch/alpha/include/asm/
>> H A D   cacheflush.h    66 /* This is used only in do_no_page and do_swap_page. */
>>  /linux-2.6-git/arch/avr32/mm/
>> H A D   cache.c         116 * This one is called from do_no_page(), do_swap_page() and install_page().
>>  /linux-2.6-git/mm/
>> H A D   memory.c        2121 * and do_anonymous_page and do_no_page can safely check later on).
>> 2319 * do_no_page is protected similarly.
>
> Nice catch :-) Cloud I assemble all fixes into one patch?
>
>  ozaki-r
>

When you resend the patch, Please Cc Jiri Kosina <trivial@...nel.org>


-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/