linux-kernel - Re: [patch 34/75] arm: ep93xx: Kill another instance of broken irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1102111240190.31804@localhost6.localdomain6>
Date:	Fri, 11 Feb 2011 12:42:29 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Ryan Mallon <ryan@...ewatersys.com>
cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Hartley Sweeten <hsweeten@...ionengravers.com>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [patch 34/75] arm: ep93xx: Kill another instance of broken
 irq_desc fiddling

On Fri, 11 Feb 2011, Ryan Mallon wrote:

> On 02/11/2011 12:37 PM, Thomas Gleixner wrote:
> > 1. This is a copy of the borked code in gpiolib
> > 2. If you need information about irq state which is not exposed, then talk
> >    to the maintainer of that code instead of adding totaly horrible open
> >    coded access.
> 
> This code got added simply because it is sometimes helpful to be able to
> see how various gpio/irq pins are configured. I'm happy to drop the
> functionality (see below), but is there a better way to get this
> information? Is it already available somewhere else (proc, sys)?

No, but we can add that if it's required in a sane form.

I don't have objections to expose debug informations in general, but
I have objections that random code does this especially, when it's
duplicated random code :)

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/