linux-kernel - Re: [patch 00/75] genirq: Overhaul for 2.6.39

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1102110135320.31804@localhost6.localdomain6>
Date:	Fri, 11 Feb 2011 01:49:17 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-arch@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [patch 00/75] genirq: Overhaul for 2.6.39

On Thu, 10 Feb 2011, Linus Torvalds wrote:

> On Thu, Feb 10, 2011 at 4:00 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> >
> >  29 files changed, 1353 insertions(+), 899 deletions(-)
> 
> So what is it that adds so many lines? Your description made me think
> "cleanups", not "50% more code"
> 
> (Yeah, yeah, I could look at the code, but I also want to point out
> that this really doesn't look like much of an improvement from a
> high-level standpoint)

Part of it is then namespace cleanup which makes the deprecated
functions wrappers around the new ones. Easy to solve with a script.

More stuff will go way again when the wrappers which I added to
prevent wreckage of arch/* fiddling with irq_desc are gone

The other things are simple inline functions which provide accessors
to state which is intentionally named:

   state_use_accessors, 

For simple reasons:

1) while you type it it should click that you're doing something wrong

2) easy to grep for to find offenderrs. git grep status sucks

There are more wrappers in the core code kernel/irq solely to prevent
using anything which got deprecated.

So yes, it's net more source lines, but not resulting in any binary
bloat.

Thanks,

	tglx