linux-kernel - Re: [RFC PATCH 01/13] Intel(R) MEI Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110211145316.GA13146@suse.de>
Date:	Fri, 11 Feb 2011 06:53:16 -0800
From:	Greg KH <gregkh@...e.de>
To:	"Weil, Oren jer" <oren.jer.weil@...el.com>
Cc:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"david@...dhou.se" <david@...dhou.se>,
	"Woodhouse, David" <david.woodhouse@...el.com>
Subject: Re: [RFC PATCH 01/13] Intel(R) MEI Driver

On Fri, Feb 11, 2011 at 10:57:31AM +0200, Weil, Oren jer wrote:
> Hi
> 
> 1) For the review purpose we wanted to split the patches into files, so the
> only way we found to do it is using "git diff", this is they there is not
> signed-off-by line
> Maybe I should have adding a description for every file, I can send another
> mail with the descriptions, sorry for the mess.

Again, please read the documentation on how to properly send patches.
We write it for a reason, not to just be ignored.

Actually, if you do ignore it, it's easy for us to ignore you, and
somehow I doubt you want that.

> 2) "Intel(R) Management Engine Interface (Intel(R) MEI)" - is our official
> name.

That's nice, but it's not anything that kernel developers want to see
all the time.  Drop the (R) please, it's pointless within the kernel
sources.

> 3) we ran checkpatch.pl on every file, this file my by skipped by mistake.

It wasn't the only file you skipped, I saw lots of coding style
violations in the other files, so I really don't believe you.

good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/