linux-kernel - Re: [PATCH] mtd: jedec_probe: initialise make sector erase command variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1297436787.2760.47.camel@localhost>
Date:	Fri, 11 Feb 2011 17:06:27 +0200
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	Antony Pavlov <antony@...si.msk.ru>
Cc:	dwmw2@...radead.org, linux-mtd@...ts.infradead.org,
	w.sang@...gutronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: jedec_probe: initialise make sector erase command
 variable

On Fri, 2011-02-11 at 13:00 +0300, Antony Pavlov wrote:
> In the commit 08968041bef437ec363623cd3218c2b083537ada
>  (mtd: cfi_cmdset_0002: make sector erase command variable)
> introdused a field sector_erase_cmd. In the same commit initialisation
> of cfi->sector_erase_cmd made in cfi_chip_setup()
> (file drivers/mtd/chips/cfi_probe.c), so the CFI chip has no problem:
> 
> ...
>         cfi->cfi_mode = CFI_MODE_CFI;
>         cfi->sector_erase_cmd = CMD(0x30);
> ...
> 
> But for the JEDEC chips this initialisation is not carried out,
> so the JEDEC chips have sector_erase_cmd == 0.
> 
> It's not possible symply add the line
>         p_cfi->sector_erase_cmd = CMD(0x30);
> to the cfi_jedec_setup() function be cause CMD() macros needs
> map and cfi variables. So this patch makes necessary changes.
> 
> Signed-off-by: Antony Pavlov <antony@...si.msk.ru>

Pushed to l2-mtd-2.6.git, thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/