linux-kernel - Re: [PATCH] usb: gadget: f_mass_storage: fixed a macro coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110211191340.GA11733@suse.de>
Date:	Fri, 11 Feb 2011 11:13:40 -0800
From:	Greg KH <gregkh@...e.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	ycwang <yenchengwang@...il.com>, dbrownell@...rs.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: f_mass_storage: fixed a macro coding
 style issue

On Fri, Feb 11, 2011 at 10:57:10AM -0800, Dmitry Torokhov wrote:
> On Fri, Feb 11, 2011 at 09:39:18AM -0800, Greg KH wrote:
> > On Fri, Feb 11, 2011 at 11:36:32PM +0800, ycwang wrote:
> > > Fixed a macro coding style issue.
> > 
> > What macro coding style issue did you fix?  Please be more specific and
> > resend the patch with a more complete changelog entry.
> > 
> 
> It is simply incorrect as it adds do {} while (0) to the module
> parameter constructors which are used outside of functions.
> 
> The change was never compiled.

Well, I was going to wait until the next iteration of the patch to let
the submitter know that, you just spoiled my fun of watching someone
send a obviously broken patch twice :)

It's the little things in life we live for...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/