linux-kernel - RE: [patch 34/75] arm: ep93xx: Kill another instance of broken irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0D753D10438DA54287A00B027084269764CF3F0132@AUSP01VMBX24.collaborationhost.net>
Date:	Thu, 10 Feb 2011 18:07:40 -0600
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
CC:	Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
	Russell King <linux@....linux.org.uk>
Subject: RE: [patch 34/75] arm: ep93xx: Kill another instance of broken
 irq_desc	fiddling

On Thursday, February 10, 2011 4:37 PM, Thomas Gleixner wrote:
>
> 1. This is a copy of the borked code in gpiolib
> 2. If you need information about irq state which is not exposed, then talk
>    to the maintainer of that code instead of adding totaly horrible open
>    coded access.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Russell King <linux@....linux.org.uk>

As stated, this was following what was provided in gpiolib.

The information was only provided by debugfs to help development.  It's
not necessarily needed.

Minor note below.  But otherwise,

Acked-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

> ---
>  arch/arm/mach-ep93xx/gpio.c |   38 --------------------------------------
>  1 file changed, 38 deletions(-)
> 
> Index: linux-2.6-tip/arch/arm/mach-ep93xx/gpio.c
> ===================================================================
> --- linux-2.6-tip.orig/arch/arm/mach-ep93xx/gpio.c
> +++ linux-2.6-tip/arch/arm/mach-ep93xx/gpio.c
> @@ -354,44 +354,6 @@ static void ep93xx_gpio_dbg_show(struct 
>  				is_out ? "out" : "in ",
>  				(data_reg & (1 << i)) ? "hi" : "lo");
>  
> -		if (!is_out) {
> -			int irq = gpio_to_irq(gpio);
> -			struct irq_desc *desc = irq_desc + irq;
> -
> -			if (irq >= 0 && desc->action) {
> -				char *trigger;
> -
> -				switch (desc->status & IRQ_TYPE_SENSE_MASK) {
> -				case IRQ_TYPE_NONE:
> -					trigger = "(default)";
> -					break;
> -				case IRQ_TYPE_EDGE_FALLING:
> -					trigger = "edge-falling";
> -					break;
> -				case IRQ_TYPE_EDGE_RISING:
> -					trigger = "edge-rising";
> -					break;
> -				case IRQ_TYPE_EDGE_BOTH:
> -					trigger = "edge-both";
> -					break;
> -				case IRQ_TYPE_LEVEL_HIGH:
> -					trigger = "level-high";
> -					break;
> -				case IRQ_TYPE_LEVEL_LOW:
> -					trigger = "level-low";
> -					break;
> -				default:
> -					trigger = "?trigger?";
> -					break;
> -				}
> -
> -				seq_printf(s, " irq-%d %s%s",
> -						irq, trigger,
> -						(desc->status & IRQ_WAKEUP)
> -							? " wakeup" : "");
> -			}
> -		}
> -
>  		seq_printf(s, "\n");

This could just be merged into the previous seq_printf().

For that matter, the is_out variable could be removed and just code the test
into the seq_printf().

>  	}
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/