linux-kernel - Re: [RFC Patch] virtio: export model and type in /sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110212071711.GB18475@infradead.org>
Date:	Sat, 12 Feb 2011 02:17:11 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Cong Wang <amwang@...hat.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org,
	Stephen Hemminger <shemminger@...tta.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	"Michael S. Tsirkin" <mst@...hat.com>,
	Anthony Liguori <aliguori@...ibm.com>,
	Jamie Lokier <jamie@...reable.org>,
	Thomas Weber <swirl@....li>,
	Ben Hutchings <ben@...adent.org.uk>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Andy Fleming <afleming@...escale.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC Patch] virtio: export model and type in /sys

On Fri, Feb 04, 2011 at 02:29:55PM +0800, Cong Wang wrote:
> >It does not make any sense to fill this at all in virtio.  The
> >attributes are simply exporting the SCSI INQUIRY data, and do not make
> >any sense at all outside a SCSI context.  In fact the type field even
> >contains numbers from the scsi protocol spec that just don't make sense.
> >
> 
> Hmm, so other non-SCSI devices don't have these neither?
> Do you have any suggestions to find another way to identify a disk?

Many modern disks have uuid strings identifying them, e.g. virtio-blk
has a serial attribute for it.  For SCSI and ATA they are retreived
by issuing the commands to get them through the pass through ioctls
right now, but I'd love to see the serial sysfs attribute implemented
there as well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/