linux-kernel - Re: [PATCH] loop: clear read-only flag in loop_clr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <E1PoilV-0002pC-6Z@be1.7eggert.dyndns.org>
Date:	Sun, 13 Feb 2011 21:41:51 +0100
From:	Bodo Eggert 
	<arcoristkaputtundbrauchtdiesentext.7eggert@...fuerspam.de>
To:	Tao Ma <tm@....ma>, linux-kernel@...r.kernel.org,
	Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] loop: clear read-only flag in loop_clr_fd.

Tao Ma <tm@....ma> wrote:

> --- a/drivers/block/loop.c

> -     if (bdev)
> +     if (bdev) {
> +             set_device_ro(bdev, 0);
>  invalidate_bdev(bdev);
> +     }
>  set_capacity(lo->lo_disk, 0);
>  loop_sysfs_exit(lo);
>  if (bdev) {

This looks like set_device_ro() should imply invalidate_bdev().
-- 
E.G.G.E.R.T.: Electronic Guardian Generated for 
              Efficient Repair and Troubleshooting
        -- http://www.brunching.com/toys/toy-cyborger.html (down)
Friß, Spammer: PanIhbEe3@...eggert.dyndns.org iNEC@...oe.7eggert.dyndns.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/