[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTikrZZ6i6di-c0zBav0zT5OOvmOXvX7SAXTW18z+@mail.gmail.com>
Date: Sun, 13 Feb 2011 18:46:55 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Justin Mattock <justinmattock@...il.com>
Cc: dri-devel@...ts.freedesktop.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
airlied@...hat.com
Subject: Re: [BISECTED] commit 619efb1059 makes the MacBookPro2,2 screen
flicker like its broken or half plugged in
On Sun, Feb 13, 2011 at 12:28 AM, Justin Mattock
<justinmattock@...il.com> wrote:
>
> On Feb 11, 2011, at 5:15 PM, Alex Deucher wrote:
>
>> On Fri, Feb 11, 2011 at 10:57 AM, Justin Mattock
>> <justinmattock@...il.com> wrote:
>>>
>>>>
>>>> Better yet, can you try the attached patch on top of 2.6.38-rc4 or
>>>> newer?
>>>>
>>>> Alex
>>>>
>>>
>>> o.k. applied that patch... unfortunately Im seeing the flickering screen
>>> and
>>> the crud shows up..
>>> initially during boot everything looked fine, its when I suspended the
>>> machine, upon wake-up
>>> the flickering occurred.
>>> kernel version is the current: 2.6.38-rc4-00107-gaa502b4
>>
>> Can you try this patch? Try uncommenting the following lines to see
>> if either of those flags work any better. Try them individually and
>> together if possible and report back which, if any, helps.
>>
>> /*pll->flags |= RADEON_PLL_PREFER_MINM_OVER_MAXP;*/
>>
>> /*if (ASIC_IS_AVIVO(rdev))
>> pll->flags |= RADEON_PLL_USE_FRAC_FB_DIV;*/
>>
>> Thanks!
>>
>> Alex
>>
>>>
>>> Justin P. Mattock
>>>
>> <0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real-v2.patch>
>
>
> alright.. again out of my office trying to make a living!!
> Anyways I applied the two earlier patches, and added the previous post's
> patch as well
> (everything runs o.k. s2r etc...)
> I can try for the above and see if I can pinpoint the piece of code that is
> causing this(hopefully)
The attached patch is what I'm proposing to go upstream. Please test
and let me know if it works ok for you.
Alex
>
> Justin P. Mattock
>
View attachment "0001-drm-radeon-kms-hopefully-fix-pll-issues-for-real-v3.patch" of type "text/x-patch" (3241 bytes)
Powered by blists - more mailing lists