| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110214140755.GL18742@htj.dyndns.org> Date: Mon, 14 Feb 2011 15:07:55 +0100 From: Tejun Heo <tj@...nel.org> To: Milan Broz <mbroz@...hat.com> Cc: Tao Ma <tm@....ma>, linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>, device-mapper development <dm-devel@...hat.com> Subject: Re: [PATCH] loop: clear read-only flag in loop_clr_fd. Hello, Milan. On Mon, Feb 14, 2011 at 12:47:48PM +0100, Milan Broz wrote: > With patch below (loop cannot be built as module) it fixes the loop problem. Okay. > But it doesn't fix the read-only snapshot issue and I guess there will be > the same problem with read-only MD code too. > (so the 2) issue here https://lkml.org/lkml/2011/2/12/209). > > If the call is changed intentionally, we have to fix unconditional blkdev open > calls with read-write flag in this code. > Before doing that I would like to know if it was intentional change or not... Yeap, the change was intentional. It was part of effort to make bdev usages more consistent as before there was no mechanism enforcing ro. It's still problematic as bdev users can clear ro without consulting the actual device driver. Device driver's ->open() is called w/ ro flag but the resulting bdev can be used rw. I wanted to remove that too but filesystems depend on it so maybe later. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists