linux-kernel - char/ipmi: cleanup_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110214150310.GA4350@swordfish.minsk.epam.com>
Date:	Mon, 14 Feb 2011 17:03:10 +0200
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Corey Minyard <minyard@....org>,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Peter Huewe <peterhuewe@....de>,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: char/ipmi: cleanup_one_si section mismatch

Hello,

commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
Author: Corey Minyard <minyard@....org>
Date:   Thu Feb 10 16:08:38 2011 -0600

    char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver


Introduced section mismatch by calling __exit cleanup_ipmi_si 
from __devinit init_ipmi_si. Should we remove __exit annotation then?


---

 drivers/char/ipmi/ipmi_si_intf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 7855f9f..94cd2ce 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
 	kfree(to_clean);
 }
 
-static void __exit cleanup_ipmi_si(void)
+static void cleanup_ipmi_si(void)
 {
 	struct smi_info *e, *tmp_e;
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/