| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20110214.113645.189699477.davem@davemloft.net> Date: Mon, 14 Feb 2011 11:36:45 -0800 (PST) From: David Miller <davem@...emloft.net> To: therbert@...gle.com Cc: segoon@...nwall.com, adobriyan@...il.com, linux-kernel@...r.kernel.org, eric.dumazet@...il.com, xiaosuo@...il.com, jesse@...ira.com, netdev@...r.kernel.org Subject: Re: [PATCH v2] core: dev: don't call BUG() on bad input From: Tom Herbert <therbert@...gle.com> Date: Mon, 14 Feb 2011 11:33:29 -0800 > On Mon, Feb 14, 2011 at 11:25 AM, David Miller <davem@...emloft.net> wrote: >> From: Vasiliy Kulikov <segoon@...nwall.com> >> Date: Mon, 14 Feb 2011 18:23:10 +0300 >> >>> On Mon, Feb 14, 2011 at 17:16 +0200, Alexey Dobriyan wrote: >>>> Netdevice name isn't some random junk you get from userspace, so BUG is fine. >>> >>> It IS for bluetooth, see net/bluetooth/bnep/core.c: bnep_add_connection() and >>> net/bluetooth/bnep/sock.c: bnep_sock_ioctl(). >> >> If bluetooth wants to allow something so foolish, then it's bluetooth's >> responsibility to sanity check the arguments before blinding passing >> them into kernel APIs which expect sane inputs. >> >> I'm not applying this. >> > > Changing to BUG_ON(txqs < 1) and BUG_ON(rxqs < 1) does make sense I think. Sure. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists