linux-kernel - Re: [patch] drivers: gpio: sx150x: Do not access I2C from mask/unmask functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110214194546.GA10940@gbean-linux.qualcomm.com>
Date:	Mon, 14 Feb 2011 11:45:46 -0800
From:	Gregory Bean <gbean@...eaurora.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jean Delvare <khali@...ux-fr.org>,
	Lennert Buytenhek <buytenh@...retlab.ca>,
	rvaswani@...eaurora.org
Subject: Re: [patch] drivers: gpio: sx150x: Do not access I2C from
 mask/unmask functions

>  static int sx150x_irq_set_type(struct irq_data *d, unsigned int flow_type)
> @@ -350,7 +353,7 @@ static int sx150x_irq_set_type(struct ir
>  
>  	chip->irq_sense &= ~(3UL << (n * 2));
>  	chip->irq_sense |= val << (n * 2);
> -	chip->irq_set_type_pending |= BIT(n);
> +	chip->update = n;

Should this be irq_update?

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/