linux-kernel - Re: [PATCH][trivial] iSCSI HBA Transport, target: Fix duplicate include and typo in drivers/target/target_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1297725651.29207.39.camel@haakon2.linux-iscsi.org>
Date:	Mon, 14 Feb 2011 15:20:51 -0800
From:	"Nicholas A. Bellinger" <nab@...ingtidesystems.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org,
	James Bottomley <James.Bottomley@...e.de>, trivial@...nel.org
Subject: Re: [PATCH][trivial] iSCSI HBA Transport, target: Fix duplicate
	include and typo in drivers/target/target_core_hba.c

On Tue, 2011-02-15 at 00:02 +0100, Jesper Juhl wrote:
> target/target_core_device.h is included twice in 
> drivers/target/target_core_hba.c .  This patch removes the duplicate.
> Also correct a typo: copntains --> contains .
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
> 
> diff --git a/drivers/target/target_core_hba.c b/drivers/target/target_core_hba.c
> index 4bbe820..8780ba8 100644
> --- a/drivers/target/target_core_hba.c
> +++ b/drivers/target/target_core_hba.c
> @@ -1,7 +1,7 @@
>  /*******************************************************************************
>   * Filename:  target_core_hba.c
>   *
> - * This file copntains the iSCSI HBA Transport related functions.
> + * This file contains the iSCSI HBA Transport related functions.
>   *
>   * Copyright (c) 2003, 2004, 2005 PyX Technologies, Inc.
>   * Copyright (c) 2005, 2006, 2007 SBE, Inc.
> @@ -38,7 +38,6 @@
>  

Ok, I will be going through and updating the copyrights soon, and I will
include this spelling correction.

>  #include <target/target_core_base.h>
>  #include <target/target_core_device.h>
> -#include <target/target_core_device.h>
>  #include <target/target_core_tpg.h>
>  #include <target/target_core_transport.h>
>  

This extra include has been removed in lio-core-2.6.git, but has not
made it to mainline just yet.

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/