[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20110214094402.4eefe70d.kamezawa.hiroyu@jp.fujitsu.com>
Date: Mon, 14 Feb 2011 09:44:02 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Matt Helsley <matthltc@...ibm.com>
Cc: jacob.jun.pan@...ux.intel.com, LKML <linux-kernel@...r.kernel.org>,
"Kirill A. Shutemov" <kirill@...temov.name>,
Arjan van de Ven <arjan@...ux.intel.com>,
container cgroup <containers@...ts.linux-foundation.org>,
Li Zefan <lizf@...fujitsu.com>,
Paul Menage <menage@...gle.com>, akpm@...ux-foundation.org,
rdunlap@...otime.net, Cedric Le Goater <clg@...t.ibm.com>
Subject: Re: [PATCH 1/1, v7] cgroup/freezer: add per freezer duty ratio
control
On Sat, 12 Feb 2011 15:29:07 -0800
Matt Helsley <matthltc@...ibm.com> wrote:
> On Fri, Feb 11, 2011 at 11:10:44AM -0800, jacob.jun.pan@...ux.intel.com wrote:
> > From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> >
> > Freezer subsystem is used to manage batch jobs which can start
> > stop at the same time. However, sometime it is desirable to let
> > the kernel manage the freezer state automatically with a given
> > duty ratio.
> > For example, if we want to reduce the time that backgroup apps
> > are allowed to run we can put them into a freezer subsystem and
> > set the kernel to turn them THAWED/FROZEN at given duty ratio.
> >
> > This patch introduces two file nodes under cgroup
> > freezer.duty_ratio_pct and freezer.period_sec
>
> Again: I don't think this is the right approach in the long term.
> It would be better not to add this interface and instead enable the
> cpu cgroup subsystem for non-rt tasks using a similar duty ratio
> concept..
>
> Nevertheless, I've added some feedback on the code for you here :).
>
AFAIK, there was a work for bandwidth control in CFS.
http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-10/msg04335.html
I tested this and worked fine. This schduler approach seems better for
my purpose to limit bandwidth of apprications rather than freezer.
BTW, isn't period_sec too large ?
Thanks,
-Kame
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists