linux-kernel - Re: [PATCH 5/6] x86: ifdef ioapic related function out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110214110039.GA7140@elte.hu>
Date:	Mon, 14 Feb 2011 12:00:39 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Henrik Kretzschmar <henne@...htwindheim.de>
Cc:	mingo@...dhat.com, tglx@...utronix.de, hpa@...or.com,
	x86@...nel.org, tj@...nel.org, yinghai@...nel.org,
	ak@...ux.intel.com, robert.richter@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] x86: ifdef ioapic related function out


* Henrik Kretzschmar <henne@...htwindheim.de> wrote:

> arch_disable_smp_config() is an IO-APIC related function on x86,
> and should only be needed if SMP is enabled.
> But the IO-APIC code calls it when the parameter "noapic" is given to
> the kernel, which doesn't mean SMP is enabled.
> 
> Anyway this fixes compilation on x86_32 UP systems with APIC and no IO-APIC.
> 
> Signed-off-by: Henrik Kretzschmar <henne@...htwindheim.de>
> ---
>  arch/x86/kernel/apic/apic.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 999c531..4998f0a 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -1218,7 +1218,9 @@ void __cpuinit setup_local_APIC(void)
>  		rdtscll(tsc);
>  
>  	if (disable_apic) {
> +#ifdef CONFIG_X86_IO_APIC
>  		arch_disable_smp_support();
> +#endif

Why not make the arch_disable_smp_support() call generic in the 
arch/x86/include/asm/smp.h file (via an inline helper) and thus
avoid an ugly #ifdef in the .c file?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/