linux-kernel - Re: [PATCH] usb_storage: realtek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D5A3E6A.6020800@gmail.com>
Date:	Tue, 15 Feb 2011 09:50:50 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	wei_wang@...lsil.com.cn
CC:	gregkh@...e.de, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb_storage: realtek_cr patch: fix sparse warning

On 02/15/2011 02:38 AM, wei_wang@...lsil.com.cn wrote:
> From: wwang <wei_wang@...lsil.com.cn>
> 
> Fix some sparse warning for realtek_cr patch
> 
> Signed-off-by: wwang <wei_wang@...lsil.com.cn>
> ---
>  drivers/usb/storage/realtek_cr.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c
> index c2bebb3..4f6b25f 100644
> --- a/drivers/usb/storage/realtek_cr.c
> +++ b/drivers/usb/storage/realtek_cr.c
> @@ -141,7 +141,7 @@ static int init_realtek_cr(struct us_data *us);
>  	.driver_info = (flags)|(USB_US_TYPE_STOR<<24)\
>  }
>  
> -struct usb_device_id realtek_cr_ids[] = {
> +static struct usb_device_id realtek_cr_ids[] = {

And it may be const too while you are at it...

regards,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/