linux-kernel - Re: [PATCH] mcp23s08: support mcp23s17 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87mxlxa2if.fsf@macbook.be.48ers.dk>
Date:	Tue, 15 Feb 2011 13:47:04 +0100
From:	Peter Korsgaard <jacmet@...site.dk>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	dbrownell@...rs.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mcp23s08: support mcp23s17 variant

>>>>> "Grant" == Grant Likely <grant.likely@...retlab.ca> writes:

Hi,

 >> We could. I didn't do it because the 8bit and 16bit cases are very
 >> similar, and checking a simple integer is presumably a lot faster than
 >> the spi access - But I can rework the patch if you insists.

 Grant> I won't insist, but it really does look like something that should
 Grant> have separate accessors from a code maintenance perspective.

Ok, I've just respun the patch with seperate accessors.

 >> I wouldn't call it unrelated. It's to ensure it still lines up after the
 >> s/u8/unsigned/.

 Grant> Sorry, you're right.  I missed the s/u8/unsigned/ change.  I don't
 Grant> have any problem with whitespace changes in a hunk that is also
 Grant> getting a real change.

Ok, good.

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/