linux-kernel - Patch "kernel/user.c: add lock release annotation on free_user()" has been added to the 2.6.32-longterm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12978102701595@kroah.org>
Date:	Tue, 15 Feb 2011 14:51:10 -0800
From:	<gregkh@...e.de>
To:	namhyung@...il.com, akpm@...ux-foundation.org,
	a.p.zijlstra@...llo.nl, dhaval.giani@...il.com, efault@....de,
	gregkh@...e.de, linux-kernel@...r.kernel.org, mingo@...e.hu,
	torvalds@...ux-foundation.org
Cc:	<stable@...nel.org>, <stable-commits@...r.kernel.org>
Subject: Patch "kernel/user.c: add lock release annotation on free_user()" has been added to the 2.6.32-longterm tree


This is a note to let you know that I've just added the patch titled

    kernel/user.c: add lock release annotation on free_user()

to the 2.6.32-longterm tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/longterm/longterm-queue-2.6.32.git;a=summary

The filename of the patch is:
     kernel-user.c-add-lock-release-annotation-on-free_user.patch
and it can be found in the queue-2.6.32 subdirectory.

If you, or anyone else, feels it should not be added to the 2.6.32 longterm tree,
please let <stable@...nel.org> know about it.


>From efault@....de  Tue Feb 15 14:39:42 2011
From: Namhyung Kim <namhyung@...il.com>
From: Mike Galbraith <efault@....de>
Date: Fri, 11 Feb 2011 07:07:01 +0100
Subject: kernel/user.c: add lock release annotation on free_user()
To: Dhaval Giani <dhaval.giani@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Ingo Molnar <mingo@...e.hu>, Greg Kroah-Hartman <gregkh@...e.de>
Message-ID: <1297404421.7865.24.camel@...ge.simson.net>


From: Namhyung Kim <namhyung@...il.com>

commit 571428be550fbe37160596995e96ad398873fcbd upstream.

free_user() releases uidhash_lock but was missing annotation.  Add it.
This removes following sparse warnings:

 include/linux/spinlock.h:339:9: warning: context imbalance in 'free_user' - unexpected unlock
 kernel/user.c:120:6: warning: context imbalance in 'free_uid' - wrong count at exit

Signed-off-by: Namhyung Kim <namhyung@...il.com>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Dhaval Giani <dhaval.giani@...il.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
Signed-off-by: Mike Galbraith <efault@....de>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>


---
 kernel/user.c |    1 +
 1 file changed, 1 insertion(+)

--- a/kernel/user.c
+++ b/kernel/user.c
@@ -91,6 +91,7 @@ static struct user_struct *uid_hash_find
  * upon function exit.
  */
 static void free_user(struct user_struct *up, unsigned long flags)
+	__releases(&uidhash_lock)
 {
 	uid_hash_remove(up);
 	spin_unlock_irqrestore(&uidhash_lock, flags);


Patches currently in longterm-queue-2.6.32 which might be from namhyung@...il.com are

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/