linux-kernel - Re: [PATCH] staging: rts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110216020944.GA29648@suse.de>
Date:	Tue, 15 Feb 2011 18:09:44 -0800
From:	Greg KH <gregkh@...e.de>
To:	wei_wang@...lsil.com.cn
Cc:	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts_pstor: fix sparse warning

On Wed, Feb 16, 2011 at 09:43:38AM +0800, wei_wang@...lsil.com.cn wrote:
> From: wwang <wei_wang@...lsil.com.cn>
> 
> Add static modifier before some function definitions; delete function
> named rtsx_transfer_sglist which won't be called.

Thanks for describing this better.

And now that we can easily see that you are doing more than one thing in
this patch, please redo it, only doing one-thing-per-patch as is the way
we require patches to be.

Care to resend this as a series of patches?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/