linux-kernel - Re: [PATCH v3] pci: use security_capable() when checking capablities during config space read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinS2dGVgPMNW=k6xVbWgQwxkopKVW_9YYtCZX8G@mail.gmail.com>
Date:	Wed, 16 Feb 2011 07:24:34 +0100
From:	Alex Riesen <raa.lkml@...il.com>
To:	Chris Wright <chrisw@...s-sol.org>
Cc:	James Morris <jmorris@...ei.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Dave Airlie <airlied@...il.com>,
	Dave Young <hidave.darkstar@...il.com>,
	linux-kernel@...r.kernel.org, David Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org,
	Sedat Dilek <sedat.dilek@...glemail.com>,
	Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH v3] pci: use security_capable() when checking capablities
 during config space read

On Tue, Feb 15, 2011 at 02:21, Chris Wright <chrisw@...s-sol.org> wrote:
> This reintroduces commit 47970b1b which was subsequently reverted
> as f00eaeea.  The original change was broken and caused X startup
> failures and generally made privileged processes incapable of reading
> device dependent config space.  The normal capable() interface returns
> true on success, but the LSM interface returns 0 on success.  This thinko
> is now fixed in this patch, and has been confirmed to work properly.
>
> So, once again...Eric Paris noted that commit de139a3 ("pci: check caps
> from sysfs file open to read device dependent config space") caused the
> capability check to bypass security modules and potentially auditing.
> Rectify this by calling security_capable() when checking the open file's
> capabilities for config space reads.
>
> Reported-by: Eric Paris <eparis@...hat.com>
> Tested-by: Dave Young <hidave.darkstar@...il.com>
> Acked-by: James Morris <jmorris@...ei.org>
> Cc: Dave Airlie <airlied@...il.com>
> Cc: Alex Riesen <raa.lkml@...il.com>
> Cc: Sedat Dilek <sedat.dilek@...glemail.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Chris Wright <chrisw@...s-sol.org>

FWIW, I confirm the fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/