linux-kernel - Re: [PATCH 0/10] Add yaffs2 file system: Fifth patchset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110216080419.GA21261@infradead.org>
Date:	Wed, 16 Feb 2011 03:04:20 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	Charles Manning <manningc2@...rix.gen.nz>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Charles Manning <cdhmanning@...il.com>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	ryan@...ewatersys.com, akpm@...ux-foundation.org
Subject: Re: [PATCH 0/10] Add yaffs2 file system:  Fifth patchset

On Thu, Feb 10, 2011 at 07:22:47AM +1300, Charles Manning wrote:
> Can you be a bit more specific?

Just compare the mes in yaffs_linux.c with a normal linux filesystem.
All that gross magic nfsd detection in readdir could have been removed
long ago.  ->readlink should not be implemented by a normal filesystem
but use generic_readlink, the fs-specific inode should embedd the vfs
inode instead of requiring two allocations, tons of useless function
pointer indirections like sb_dirty_fn and the put_super_fn really must
go away.  The procfs interfaces should be replaced by something saner,
the insane amount of ad-hoc tracing crap should be replaced by much
less strategically placed trace events, and all those stupid compile
time options have absolutely no business at all beeing there for a
filesystem - remember you can get media from all over the place.
If you can't encode these difference in your on-disk format it has
absolutely no business going into mainline with this format.

And last but not least there's no way we'll merge a filesystem with a
global mutex and all kinds of hacky release and reaquire semantics
these days.  I really think you need to get back to the drawing board.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/