linux-kernel - Re: [PATCH v2] olpc_battery: convert to platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110216165247.GC29796@core.coreip.homeip.net>
Date:	Wed, 16 Feb 2011 08:52:48 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Daniel Drake <dsd@...top.org>
Cc:	cbou@...l.ru, dwmw2@...radead.org, linux-kernel@...r.kernel.org,
	x86@...nel.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, dilinger@...ued.net
Subject: Re: [PATCH v2] olpc_battery: convert to platform device

On Wed, Feb 16, 2011 at 02:29:31PM +0000, Daniel Drake wrote:
>  
> -static void __exit olpc_bat_exit(void)
> +static int __exit olpc_battery_remove(struct platform_device *pdev)
...
> +	.remove = __devexit_p(olpc_battery_remove),

olpc_battery_remove should be annotated as __devexit. Sorry for not
noticing this before. Otherwise:

Reviewed-by: Dmitry Torokhov <dtor@...l.ru>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/