linux-kernel - Re: [PATCH 00/10] [GIT PULL][v2.6.39] tracing: updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Feb 2011 10:03:00 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 00/10] [GIT PULL][v2.6.39] tracing: updates

On Thu, 2011-02-17 at 15:04 +0100, Ingo Molnar wrote:
> > > Please pull the latest tip/perf/core tree, which can be found at:
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
> > > tip/perf/core
> 
> Note that these changes caused a new build failure on arch/m32r:
> 
> /home/mingo/tip/drivers/net/smc91x.h:199:1: warning: this is the location of the previous definition
> /home/mingo/tip/kernel/trace/ring_buffer.c: In function 'rb_reserve_next_event':
> /home/mingo/tip/kernel/trace/ring_buffer.c:2165: error: 'sched_clock_stable' undeclared (first use in this function)
> /home/mingo/tip/kernel/trace/ring_buffer.c:2165: error: (Each undeclared identifier is reported only once
> /home/mingo/tip/kernel/trace/ring_buffer.c:2165: error: for each function it appears in.)
> make[3]: *** [kernel/trace/ring_buffer.o] Error 1
> make[2]: *** [kernel/trace] Error 2

Ah, patch "tracing: Add unstable sched clock note to the warning"
referenced sched_clock_stable without encompassing it with:

#ifdef CONFIG_HAVE_UNSTABLE_SCHED_CLOCK

I wonder if we could instead in linux/sched.h add in the ifndef part:

#define sched_clock_stable 1

That way generic code can still reference this variable without having
to litter the code with #ifdef's.

Thoughts?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/