linux-kernel - Re: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D5D9A00.7060609@codeaurora.org>
Date:	Thu, 17 Feb 2011 13:58:24 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Jamie Iles <jamie@...ieiles.com>
CC:	John Linn <john.linn@...inx.com>, linux@....linux.org.uk,
	arnd@...db.de, catalin.marinas@....com,
	linux-kernel@...r.kernel.org, glikely@...retlab.ca,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3 3/4] ARM: Xilinx: base header files and assembly macros

On 02/17/2011 02:01 AM, Jamie Iles wrote:
>> +
>> +static void putc(char ch)
>> +{
>> +	/*
>> +	 * Wait for room in the FIFO, then write the char into the FIFO
>> +	 */
>> +	while (UART_STATUS(LL_UART_PADDR) & UART_SR_TXFULL)
>> +		;
>
> It might be worth adding a barrier() call to these loops to be explicit 
> about the volatility.

I think you want cpu_relax() then.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/