linux-kernel - RE: [PATCH v4 1/1] [media] ov9740: Initial submit of OV9740 driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Feb 2011 15:26:17 -0800
From:	Andrew Chew <AChew@...dia.com>
To:	'Guennadi Liakhovetski' <g.liakhovetski@....de>
CC:	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mchehab@...hat.com" <mchehab@...hat.com>,
	"hverkuil@...all.nl" <hverkuil@...all.nl>
Subject: RE: [PATCH v4 1/1] [media] ov9740: Initial submit of OV9740 driver.

> This looks good now, thanks, I'll queue it for 2.6.39. Just 
> one question:
> 
> On Thu, 17 Feb 2011, achew@...dia.com wrote:
> 
> > From: Andrew Chew <achew@...dia.com>
> > 
> > This soc_camera driver is for Omnivision's OV9740 sensor.  
> This initial
> > submission provides support for YUV422 output at 1280x720 
> (720p), which is
> > the sensor's native resolution.  640x480 (VGA) is also 
> supported, with
> > cropping and scaling performed by the sensor's ISP.
> 
> Didn't you mean to say just "scaling?" You're not 
> implementing cropping. 
> You could, certainly, fake scaling with cropping, but are you 
> really using 
> both to switch between 720p and VGA? No need for a v5, just 
> tell me how to 
> change the comment.

There really is cropping.  The native resolution of the OV9740 sensor is a different aspect ratio than VGA.  To preserve the square pixels, first we crop both the left and right sides, and then scale down.--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/