linux-kernel - Re: [PATCH v2 09/13] can: pruss CAN driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <184FA07B783D4F5FAAC09D5C11737A3F@subhasishg>
Date:	Fri, 18 Feb 2011 13:45:57 +0530
From:	"Subhasish Ghosh" <subhasish@...tralsolutions.com>
To:	"Wolfgang Grandegger" <wg@...ndegger.com>
Cc:	"Kurt Van Dijck" <kurt.van.dijck@....be>,
	<sachi@...tralsolutions.com>,
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"open list:CAN NETWORK DRIVERS" <netdev@...r.kernel.org>,
	<nsekhar@...com>, "open list" <linux-kernel@...r.kernel.org>,
	"open list:CAN NETWORK DRIVERS" <socketcan-core@...ts.berlios.de>,
	<linux-arm-kernel@...ts.infradead.org>, <m-watkins@...com>
Subject: Re: [PATCH v2 09/13] can: pruss CAN driver.

> On 02/18/2011 08:07 AM, Subhasish Ghosh wrote:
>> --------------------------------------------------
>> From: "Kurt Van Dijck" <kurt.van.dijck@....be>
>
> ...
>>>> + /* register interrupt handler */
>>>> + err = request_irq(priv->trx_irq, &omapl_rx_can_intr, IRQF_SHARED,
>>>> +   "pru_can_irq", ndev);
>>> you're doing a lot of work _in_ the irq handler. Maybe threaded irq?
>>>
>> SG -Ok, will do
>
> No, please use NAPI instead.

We are using h/w filters, so the number of interrupts coming into the 
processor are not hogging it.
I feel that we may not require an interrupt mitigation.

-Subhasish 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/