linux-kernel - Re: [Nios2-dev] [PATHV v2] tty: serial: altera

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Feb 2011 09:15:46 +0100
From:	Tobias Klauser <tklauser@...tanz.ch>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Thomas Chou <thomas@...ron.com.tw>, nios2-dev@...c.et.ntust.edu.tw,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-serial@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Nios2-dev] [PATHV v2] tty: serial: altera_uart: Add
	devicetree support

On 2011-02-18 at 09:08:53 +0100, Grant Likely <grant.likely@...retlab.ca> wrote:
> On Thu, Feb 17, 2011 at 6:28 PM, Thomas Chou <thomas@...ron.com.tw> wrote:
> > On 02/17/2011 03:48 PM, Tobias Klauser wrote:
> >>>>
> >>>> +       ret = altera_uart_get_of_uartclk(pdev, port);
> >>>> +       if (ret&&   platp)
> >>>> +               port->uartclk = platp->uartclk;
> >>>> +       else if (ret)
> >>>> +               return ret;
> >>>> +
> >>>
> >>> Better reverse the priority, with platform data checked first.
> >>>
> >>>        if (platp)
> >>>                port->uartclk = platp->uartclk;
> >>>        else {
> >>>                ret = altera_uart_get_of_uartclk(pdev, port);
> >>>                if (ret)
> >>>                        return ret;
> >>>        }
> >>
> >> Do you have a specific reasoning for this? I thought it might make sense
> >> to do it in the same order as with the resources above, but I have no
> >> problem changing it to the way you suggest.
> >
> > Not quite sure. But I see some drivers follow this order, and I just
> > followed, too.
> 
> The reason to check for platform_data first is that if a device has
> *both* platform data and a device node pointer, then more than likely
> the platform_data is indented to override the device node data.

Thanks Grant and Thomas for the explanation. I was just wondering. I'll
send an updated patch including the changes suggested by Thomas.

Tobias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/